Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10536162: Add token kind into InstanceCallComp so that we do not need to extract it from name (addresses vego… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 8672)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -444,18 +444,19 @@
}
+
+
void FlowGraphOptimizer::VisitInstanceCall(InstanceCallComp* comp) {
if (comp->HasICData() && (comp->ic_data()->NumberOfChecks() > 0)) {
- const String& function_name = comp->function_name();
- Token::Kind op_kind = Token::GetBinaryOp(function_name);
- if ((op_kind != Token::kILLEGAL) && TryReplaceWithBinaryOp(comp, op_kind)) {
+ const Token::Kind op_kind = comp->token_kind();
+ if (Token::IsBinaryToken(op_kind) &&
+ TryReplaceWithBinaryOp(comp, op_kind)) {
return;
}
- op_kind = Token::GetUnaryOp(function_name);
- if ((op_kind != Token::kILLEGAL) && TryReplaceWithUnaryOp(comp, op_kind)) {
+ if (Token::IsUnaryToken(op_kind) && TryReplaceWithUnaryOp(comp, op_kind)) {
return;
}
- if ((Field::IsGetterName(function_name)) && TryInlineInstanceGetter(comp)) {
+ if ((op_kind == Token::kGET) && TryInlineInstanceGetter(comp)) {
return;
}
if (TryInlineInstanceMethod(comp)) {
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698