Fix for issue 1601

Fix for issue 1601
Committed: https://code.google.com/p/dart/source/detail?r=8576

[scheglov, 2012-06-12 20:32:16]

LGTM

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1614: Type
returnType = node.getElement().getFunctionType().getReturnType();
This is same as methodElement.getReturnType().
Not a problem, just note.

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1615: if
(returnType != voidType) {
I'm not sure that we can rely on == to compare Types.

[Brian Wilkerson, 2012-06-12 20:50:48]

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1614: Type
returnType = node.getElement().getFunctionType().getReturnType();
> This is same as methodElement.getReturnType().

OK. I just copied the code from above, so I think I'll leave it so it's
consistent.

http://codereview.chromium.org/10533115/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1615: if
(returnType != voidType) {
> I'm not sure that we can rely on == to compare Types.

Right. I thought I had seen that there was a single instance of VoidType, but I
was wrong. Changes to use TypeKind.of(returnType).

[scheglov, 2012-06-12 20:59:20]

OK, still LGTM