compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10533115: Fix for issue 1601

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10533115: Fix for issue 1601 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

===================================================================

--- compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (revision 8551)

+++ compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (working copy)

@@ -1608,6 +1608,14 @@

typeError(returnTypeNode, TypeErrorCode.OPERATOR_NEGATE_NUM_RETURN_TYPE);

}

+ // operator "[]=" should return void

+ if (modifiers.isOperator() && methodElement.getName().equals("[]=")

+ && returnTypeNode != null) {

+ Type returnType = node.getElement().getFunctionType().getReturnType();

+ if (TypeKind.of(returnType) != TypeKind.VOID) {

+ typeError(returnTypeNode, TypeErrorCode.OPERATOR_INDEX_ASSIGN_VOID_RETURN_TYPE);

+ }

// done

return typeAsVoid(node);

}