Issue 10532024: Close stdin in Process.run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10532024: Close stdin in Process.run. (Closed)

Created:
8 years, 6 months ago by Anders Johnsen

Modified:
8 years, 6 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Close stdin in Process.run. This fixes an open pipe issue. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8321

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/bin/process_impl.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 6 months ago (2012-06-06 10:25:25 UTC) #2

LGTM! Thanks for fixing this!

Another way to fix it would be to call _process.close() in _checkDone when you
are done. I like doing it in onStart though since it also makes it explicit that
stdin is not used.

Expand Messages | Collapse Messages