Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: runtime/bin/process_impl.dart

Issue 10532024: Close stdin in Process.run. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_impl.dart
diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart
index c786f9cb3ffbd1757a90bd2935d191f9aa4221ce..bdb5d6aca4a070ea538663d47eda8f873898091d 100644
--- a/runtime/bin/process_impl.dart
+++ b/runtime/bin/process_impl.dart
@@ -331,6 +331,9 @@ class _NonInteractiveProcess {
// Start the underlying process.
_process = new _Process.start(path, arguments, options);
+ // Make sure stdin is closed.
+ _process.onStart = _process.stdin.close;
+
// Setup process error handling.
_process.onError = (e) => _completer.completeException(e);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698