Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org, sra, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Use WebKit IDL syntax for declaring optional parameters in dart.idl. Using the same syntax everywhere makes generator simpler. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=8276

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -26 lines)			Patch
M	lib/dom/idl/dart/dart.idl	View	5 chunks	+15 lines, -15 lines	0 comments	Download
M	lib/dom/scripts/databasebuilder.py	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/dom/scripts/idlnode.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	lib/dom/scripts/idlrenderer.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Anton Muhin

8 years, 6 months ago (2012-06-04 10:24:53 UTC) #2

LGTM, but, please, sync up with Stephen and Vijay if they are ok w/ it.