Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10516006: Issue 3268. Support for replacing 'assert' statement with 'assert' function (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3268. Support for replacing 'assert' statement with 'assert' function http://code.google.com/p/dart/issues/detail?id=3268 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8290

Patch Set 1 #

Total comments: 18

Patch Set 2 : Changes for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -204 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 2 chunks +6 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java View 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/ASTVisitor.java View 2 chunks +4 lines, -4 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartAssertion.java View 1 chunk +0 lines, -34 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartReturnBlock.java View 2 chunks +7 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java View 1 chunk +0 lines, -9 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 2 chunks +0 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +15 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 1 chunk +2 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 4 chunks +13 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 7 chunks +46 lines, -7 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java View 1 3 chunks +2 lines, -10 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +55 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 2 chunks +0 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java View 2 chunks +0 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyDescriptorHelper.java View 3 chunks +0 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java View 1 3 chunks +1 line, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java View 1 4 chunks +2 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java View 1 3 chunks +1 line, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java View 1 4 chunks +2 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/ASTRewriteAnalyzer.java View 2 chunks +0 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeFormatterVisitor.java View 2 chunks +0 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/NodeClassifier.java View 1 4 chunks +2 lines, -8 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 6 months ago (2012-06-05 06:22:03 UTC) #1
Brian Wilkerson
LGTM https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java File compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java (right): https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java#newcode1 compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java:1: // Copyright (c) 2011, the Dart project authors. ...
8 years, 6 months ago (2012-06-05 14:45:55 UTC) #2
scheglov
8 years, 6 months ago (2012-06-05 16:07:26 UTC) #3 
https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java (right):

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:17:
ASSERT_NUMBER_ARGUMENTS(ErrorSeverity.ERROR, "assert requires excatly one
argument"),
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> "excatly" --> "exactly"

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:18:
ASSERT_IS_STATEMENT(ErrorSeverity.ERROR, "assert is statement, it can not be
used as expression"),
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> --> "assert is a statement, it cannot be used as an expression"

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/NodeClassifier.java
(right):

https://chromiumcodereview.appspot.com/10516006/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/NodeClassifier.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/05 14:45:55, Brian Wilkerson wrote:
> nit: copyright year

Done.

Powered by Google App Engine
This is Rietveld 408576698