compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java - Issue 10516006: Issue 3268. Support for replacing 'assert' statement with 'assert' function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

Issue 10516006: Issue 3268. Support for replacing 'assert' statement with 'assert' function (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Changes for review comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

index c199c828190c67cd948f2fa3fb4db88923ad795e..e5aa3f8d66cdfd575bc43e1737044e16594eb610 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

@@ -86,7 +86,8 @@ public class ResolutionContext implements ResolutionErrorListener {

if (!Elements.isConstructorParameter(element)

&& !Elements.isParameterOfMethodWithoutBody(element)

&& !(Elements.isStaticContext(element) && !Elements.isStaticContext(existingElement))

- && !existingElement.getModifiers().isAbstractField()) {

+ && !existingElement.getModifiers().isAbstractField()

+ && !Elements.isArtificialAssertMethod(existingElement)) {

SourceInfo nameSourceInfo = element.getNameLocation();

String existingLocation = Elements.getRelativeElementLocation(element, existingElement);

// TODO(scheglov) remove condition once HTML will be fixed to don't have duplicates.