Issue 10511007: Make HBreak and HContinue not extend HGoto. They now extend HJump which is independent of HGoto. To…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10511007: Make HBreak and HContinue not extend HGoto. They now extend HJump which is independent of HGoto. To… (Closed)

Created:
8 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 6 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make HBreak and HContinue not extend HGoto. They now extend HJump which is independent of HGoto. Too many errors have occured due to HGoto having sub-classes, so checking if something is HGoto isn't enough. Committed: https://code.google.com/p/dart/source/detail?r=8318

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -15 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	2 chunks	+2 lines, -4 lines	2 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	3 chunks	+15 lines, -10 lines	0 comments	Download
M	lib/compiler/implementation/ssa/validate.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! http://codereview.chromium.org/10511007/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): http://codereview.chromium.org/10511007/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1242 lib/compiler/implementation/ssa/codegen.dart:1242: return false; one line?

8 years, 6 months ago (2012-06-06 11:05:29 UTC) #4

Lasse Reichstein Nielsen

8 years, 6 months ago (2012-06-06 13:04:07 UTC) #5

http://codereview.chromium.org/10511007/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10511007/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:1242: return false;
NEVER!
Ahem.

I'd actually rather combine it with the test above, and keep the block. 
I don't like hiding early returns at the end of innocuously looking lines.

Expand Messages | Collapse Messages