Issue 10500005: More shared code.

Issue 10500005: More shared code. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More shared code. Committed: https://code.google.com/p/dart/source/detail?r=8254

Patch Set 6 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -323 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3 4 5	2 chunks	+15 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4 5	5 chunks	+17 lines, -114 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_shared.h	View	1 2 3 4 5	2 chunks	+37 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_shared.cc	View	1 2 3 4 5	3 chunks	+134 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3 4 5	4 chunks	+13 lines, -23 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5	7 chunks	+17 lines, -115 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	2 chunks	+13 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	6 chunks	+40 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10500005/diff/13002/runtime/vm/flow_graph_compiler_shared.h File runtime/vm/flow_graph_compiler_shared.h (right): https://chromiumcodereview.appspot.com/10500005/diff/13002/runtime/vm/flow_graph_compiler_shared.h#newcode127 runtime/vm/flow_graph_compiler_shared.h:127: virtual void IntrinsifyGetter() = 0; The names are ...

8 years, 6 months ago (2012-06-04 13:05:52 UTC) #2

srdjan

8 years, 6 months ago (2012-06-04 15:52:46 UTC) #3

https://chromiumcodereview.appspot.com/10500005/diff/13002/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_shared.h (right):

https://chromiumcodereview.appspot.com/10500005/diff/13002/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_shared.h:127: virtual void IntrinsifyGetter() =
0;
On 2012/06/04 13:05:52, Vyacheslav Egorov (Google) wrote:
> The names are a bit confusing, I had to look at their bodies to understand
what
> they do. Consider adding comment.
> 
> I also don't understand why these functions are methods on FlowGraphCompiler
> because they do not use any FlowGraphCompiler infrastructure. 

Changed names to GenerateInlinedSetter/Getter, passing the offset, AST analysis
moved to shared code.

Not sure yet where we want to put all the specific code patterns, right now we
pile them up in FlowGraphCompiler, but we may want to move stuff that is not
dependent on FlowGraphCompiler.

https://chromiumcodereview.appspot.com/10500005/diff/13002/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_shared.h:129: virtual intptr_t
EmitInstanceCall(ExternalLabel* target_label,
On 2012/06/04 13:05:52, Vyacheslav Egorov (Google) wrote:
> please document return values of these functions.

  // Returns pc-offset (in bytes) of the pc after the call, can be used to emit
  // pc-descriptor information.

Expand Messages | Collapse Messages