More shared code.

runtime/vm/flow_graph_compiler_shared.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_COMPILER_SHARED_H_
 #define VM_FLOW_GRAPH_COMPILER_SHARED_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/code_descriptors.h"
@@ skipping 84 matching lines @@
                       intptr_t deopt_token_index,
                       intptr_t try_index_,
                       DeoptReasonId reason,
                       Register reg1,
                       Register reg2);
 
   void FinalizeExceptionHandlers(const Code& code);
   void FinalizePcDescriptors(const Code& code);
   void FinalizeStackmaps(const Code& code);
   void FinalizeVarDescriptors(const Code& code);
+  void FinalizeComments(const Code& code);
+
+  void GenerateInstanceCall(intptr_t cid,
+                            intptr_t token_index,
+                            intptr_t try_index,
+                            const String& function_name,
+                            intptr_t argument_count,
+                            const Array& argument_names,
+                            intptr_t checked_argument_count);
+  void GenerateStaticCall(intptr_t cid,
+                          intptr_t token_index,
+                          intptr_t try_index,
+                          const Function& function,
+                          intptr_t argument_count,
+                          const Array& argument_names);
 
   void GenerateDeferredCode();
 
+
+  // Returns 'true' if code generation for this function is complete, i.e.,
+  // no fall-through to regular code is needed.
+  bool TryIntrinsify();
+  virtual void IntrinsifyGetter() = 0;

[Vyacheslav Egorov (Google), 2012/06/04 13:05:52]

The names are a bit confusing, I had to look at their bodies to understand what
they do. Consider adding comment.

I also don't understand why these functions are methods on FlowGraphCompiler
because they do not use any FlowGraphCompiler infrastructure. 

[srdjan, 2012/06/04 15:52:46]

Changed names to GenerateInlinedSetter/Getter, passing the offset, AST analysis
moved to shared code.

Not sure yet where we want to put all the specific code patterns, right now we
pile them up in FlowGraphCompiler, but we may want to move stuff that is not
dependent on FlowGraphCompiler.

+  virtual void IntrinsifySetter() = 0;
+  virtual intptr_t EmitInstanceCall(ExternalLabel* target_label,

[Vyacheslav Egorov (Google), 2012/06/04 13:05:52]

please document return values of these functions.

[srdjan, 2012/06/04 15:52:46]

  // Returns pc-offset (in bytes) of the pc after the call, can be used to emit
  // pc-descriptor information.

+                                    const ICData& ic_data,
+                                    const Array& arguments_descriptor,
+                                    intptr_t argument_count) = 0;
+  virtual intptr_t EmitStaticCall(const Function& function,
+                                  const Array& arguments_descriptor,
+                                  intptr_t argument_count) = 0;
+
+
   struct BlockInfo : public ZoneAllocated {
    public:
     BlockInfo() : label() { }
 
     Label label;
   };
 
   const GrowableArray<BlockInfo*>& block_info() const { return block_info_; }
 
+  // Bail out of the flow graph compiler. Does not return to the caller.
+  void Bailout(const char* reason);
+
  private:
   // Map a block number in a forward iteration into the block number in the
   // corresponding reverse iteration.  Used to obtain an index into
   // block_order for reverse iterations.
   intptr_t reverse_index(intptr_t index) const {
     return block_order_.length() - index - 1;
   }
 
   class Assembler* assembler_;
   const ParsedFunction& parsed_function_;
@@ skipping 11 matching lines @@
   const bool is_optimizing_;
 
   DISALLOW_COPY_AND_ASSIGN(FlowGraphCompilerShared);
 };
 
 
 }  // namespace dart
 
 
 #endif  // VM_FLOW_GRAPH_COMPILER_SHARED_H_