Remove underscores from configurations.

Remove underscores from configurations.

Underscores don't work in Visual Studio 2010.

Committed: https://code.google.com/p/dart/source/detail?r=8235

[ahe, 2012-06-01 19:21:11]

I recreated the CL from memory (the original is on Johnni's Windows PC). I also
incorporated Ivan's suggestion.

I would like to land this ASAP, as this is a big problem for building on
Windows.

[siva, 2012-06-01 20:19:21]

DBC...

https://chromiumcodereview.appspot.com/10475003/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10475003/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/test_suite.dart:1279: String arch =
configuration['arch'].toUpperCase();
var mode = ...;
var arch = ...;

to conform to the style guide.

[Ivan Posva, 2012-06-03 15:12:12]

LGTM, but please before committing send out a warning that the build output
directory names are changing. Otherwise people might keep relying on the old
location in scripts and other tools...

-Ivan

[ricow1, 2012-06-04 05:26:49]

LGTM, but I think we need to update some svn:ignore properties here to not
completely destroy our cycle time on the buildbot. Non versioned
files/directories that does _not_ have the svn:ignore flag will be deleted by
gclient sync when running with  --delete_unversioned_trees. The buildbot slaves
runs with that. Please feel free to land this as a follow up change to make sure
that everything here is working first.

[ahe, 2012-06-04 05:37:26]

Hi Siva, Ivan, and Rico,

Thank you for your great suggestions. I'll update svn:ignore in a seperate CL as
this was started in git. I also sent out a heads up to the team.

Cheers,
Peter

[Johnni Winther, 2012-06-04 06:56:03]

lgtm

LGTM

[ahe, 2012-06-04 07:42:09]

https://chromiumcodereview.appspot.com/10475003/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10475003/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/test_suite.dart:1279: String arch =
configuration['arch'].toUpperCase();
On 2012/06/01 20:19:21, asiva wrote:
> var mode = ...;
> var arch = ...;
> 
> to conform to the style guide. 

I don't think the style guide prohibits you from using types. If it does, it
would be wrong.

In this case, types were being used already, so I think it makes sense to keep
them.

[Bill Hesse, 2012-06-04 08:24:51]

LGTM.