Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 10475003: Remove underscores from configurations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/gyp/configurations.gypi ('k') | dart/tools/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 1052f7b4fca61599a782e8abc5bb73d7bed0d9f0..ed831c7d24a27e9c4e2acbc345e93dfcb68530d6 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -1275,9 +1275,9 @@ class TestUtils {
}
static String buildDir(Map configuration) {
- String debugMode =
- (configuration['mode'] == 'debug') ? 'Debug_' : 'Release_';
- return "${outputDir(configuration)}$debugMode${configuration['arch']}";
+ String mode = (configuration['mode'] == 'debug') ? 'Debug' : 'Release';
+ String arch = configuration['arch'].toUpperCase();
siva 2012/06/01 20:19:21 var mode = ...; var arch = ...; to conform to the
ahe 2012/06/04 07:42:09 I don't think the style guide prohibits you from u
+ return "${outputDir(configuration)}$mode$arch";
}
static String dartDir() {
« no previous file with comments | « dart/tools/gyp/configurations.gypi ('k') | dart/tools/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698