Issue 10466006: Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with…

Issue 10466006: Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
regis, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with runtime calls only. Committed: https://code.google.com/p/dart/source/detail?r=8257

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+292 lines, -20 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.h	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	2 chunks	+174 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	5 chunks	+96 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	3 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode175 runtime/vm/intermediate_language_ia32.cc:175: // If the next block is the true ...

8 years, 6 months ago (2012-06-04 07:28:59 UTC) #2

regis

LGTM https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode171 runtime/vm/intermediate_language_ia32.cc:171: // If the next block is the false ...

8 years, 6 months ago (2012-06-04 11:54:34 UTC) #3

srdjan

8 years, 6 months ago (2012-06-04 16:10:47 UTC) #4

https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:171: // If the next block is the false
sucessor we will fall through to it if
On 2012/06/04 11:54:34, regis wrote:
> successor

Done.

https://chromiumcodereview.appspot.com/10466006/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:175: // If the next block is the true
sucessor we negate comparison and fall
On 2012/06/04 07:28:59, Florian Schneider wrote:
> Maybe add an ASSERT(compiler->IsNextBlock(true_successor())) here.

Done.

Expand Messages | Collapse Messages