Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with…

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 95 matching lines @@
   compiler->GenerateCallRuntime(cid(),
                                 token_index(),
                                 try_index(),
                                 kReThrowRuntimeEntry);
   __ int3();
 }
 
 
 LocationSummary* BranchInstr::MakeLocationSummary() const {
   const int kNumInputs = 1;
-  const int kNumTemps = 1;
+  const int kNumTemps = 0;
   LocationSummary* locs = new LocationSummary(kNumInputs, kNumTemps);
   locs->set_in(0, Location::RequiresRegister());
-  locs->set_temp(0, Location::RequiresRegister());
   return locs;
 }
 
 
 void BranchInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register value = locs()->in(0).reg();
-  Register temp = locs()->temp(0).reg();
 
-  __ LoadObject(temp, Bool::ZoneHandle(Bool::True()));
-  __ cmpq(value, temp);
+  __ CompareObject(value, Bool::ZoneHandle(Bool::True()));
   if (compiler->IsNextBlock(false_successor())) {
-    // If the next block is the false sucessor we will fall through to it if
+    // If the next block is the false successor we will fall through to it if
     // comparison with true fails.
     __ j(EQUAL, compiler->GetBlockLabel(true_successor()));
   } else {
-    // If the next block is the true sucessor we negate comparison and fall
+    ASSERT(compiler->IsNextBlock(true_successor()));
+    // If the next block is the true successor we negate comparison and fall
     // through to it.
     __ j(NOT_EQUAL, compiler->GetBlockLabel(false_successor()));
   }
 }
 
 
 LocationSummary* ReturnInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   const intptr_t kNumTemps = 1;
   LocationSummary* locs = new LocationSummary(kNumInputs, kNumTemps);
@@ skipping 96 matching lines @@
 
   Register left = locs()->in(0).reg();
   Register right = locs()->in(1).reg();
   Register result = locs()->out().reg();
 
   __ cmpq(left, right);
   Label load_true, done;
   if (kind() == Token::kEQ_STRICT) {
     __ j(EQUAL, &load_true, Assembler::kNearJump);
   } else {
+    ASSERT(kind() == Token::kNE_STRICT);
     __ j(NOT_EQUAL, &load_true, Assembler::kNearJump);
   }
   __ LoadObject(result, bool_false);
   __ jmp(&done, Assembler::kNearJump);
   __ Bind(&load_true);
   __ LoadObject(result, bool_true);
   __ Bind(&done);
 }
 
 
@@ skipping 302 matching lines @@
   // Preserve the value (second argument) under the arguments as the result
   // of the computation, then call the setter.
   const String& function_name =
       String::ZoneHandle(Field::SetterSymbol(field_name()));
 
   // Insert a copy of the second (last) argument under the arguments.
   // TODO(fschneider): Avoid preserving the value if the result is not used.
   __ pushq(value);
   __ pushq(receiver);
   __ pushq(value);
+  const intptr_t kArgumentCount = 2;
+  const intptr_t kCheckedArgumentCount = 1;
   compiler->GenerateInstanceCall(cid(),
                                  token_index(),
                                  try_index(),
                                  function_name,
-                                 2,
+                                 kArgumentCount,
                                  Array::ZoneHandle(),
-                                 1);
+                                 kCheckedArgumentCount);
   __ popq(result);
 }
 
 
 LocationSummary* StaticSetterComp::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   return LocationSummary::Make(kNumInputs, Location::RequiresRegister());
 }
 
 
@@ skipping 837 matching lines @@
   } else {
     UNREACHABLE();
   }
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64