Issue 10462004: Temporarily disable FlowGraphOptimizer on ia32 to make tests pass with --use_new_compiler on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10462004: Temporarily disable FlowGraphOptimizer on ia32 to make tests pass with --use_new_compiler on. (Closed)

Created:
8 years, 6 months ago by Florian Schneider

Modified:
8 years, 6 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Temporarily disable FlowGraphOptimizer on ia32 to make tests pass with --use_new_compiler on. Once we ported all instructions produced by the FlowGraphOptimizer to ia32 we can remove this code again. Committed: https://code.google.com/p/dart/source/detail?r=8200

Patch Set 1 #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	vm/compiler.cc	View		1 chunk	+6 lines, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10462004/diff/1/vm/compiler.cc File vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10462004/diff/1/vm/compiler.cc#newcode198 vm/compiler.cc:198: // TODO(fschneider): Temporarily disable on ia32 until all ...

8 years, 6 months ago (2012-06-01 13:08:41 UTC) #2

Florian Schneider

8 years, 6 months ago (2012-06-01 16:05:04 UTC) #4

https://chromiumcodereview.appspot.com/10462004/diff/1/vm/compiler.cc
File vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10462004/diff/1/vm/compiler.cc#newcode198
vm/compiler.cc:198: // TODO(fschneider): Temporarily disable on ia32 until all
instruction
On 2012/06/01 13:08:41, regis wrote:
> instructions

Done.

https://chromiumcodereview.appspot.com/10462004/diff/1/vm/compiler.cc#newcode200
vm/compiler.cc:200: #if defined(TARGET_ARCH_X64)
On 2012/06/01 13:08:41, regis wrote:
> I would have made the workaround dependent on TARGET_ARCH_IA32 instead, but
> that's fine.

Done.

Expand Messages | Collapse Messages