Access to "this" in super reads in a closure.

Access to "this" in super reads in a closure.

Committed: https://code.google.com/p/dart/source/detail?r=8154

[ahe, 2012-05-31 08:55:08]

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/tests/language/la...
File dart/tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/tests/language/la...
dart/tests/language/language.status:50: super_closure_test: Fail # Issue 3197.
Notice: this is the VM, not dart2js.

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/tests/language/su...
File dart/tests/language/super_closure_test.dart (right):

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/tests/language/su...
dart/tests/language/super_closure_test.dart:9: get x() => superX;
On a related note: we don't generate the correct code for:

class Super {
  var x = "super";
}

class Sub extends Super {
  var x = "sub";
}

The field in the subclass gets the same name as the superclass, I think. This is
covered by super_field_access_test and super_implicit_closure_test.

[ngeoffray, 2012-05-31 08:59:23]

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1565:
visitArguments(node.inputs);
Don't we get just only one input (this) ?

[ahe, 2012-05-31 09:08:32]

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1565:
visitArguments(node.inputs);
On 2012/05/31 08:59:23, ngeoffray wrote:
> Don't we get just only one input (this) ?

The input should be two things, the element and "this". "this" may not be what
JS think it is in a closure.

I'm not sure I understand your question.

[ngeoffray, 2012-05-31 09:37:07]

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10451090/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1565:
visitArguments(node.inputs);
On 2012/05/31 09:08:36, ahe wrote:
> On 2012/05/31 08:59:23, ngeoffray wrote:
> > Don't we get just only one input (this) ?
> 
> The input should be two things, the element and "this". "this" may not be what
> JS think it is in a closure.

Very good point. And doing the mistake looks quite easy. Do we have the same
problem line 1559?

> 
> I'm not sure I understand your question.

[ngeoffray, 2012-05-31 11:35:25]

LGTM