Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: dart/lib/compiler/implementation/ssa/codegen.dart

Issue 10451090: Access to "this" in super reads in a closure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/language/language.status » ('j') | dart/tests/language/language.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/ssa/codegen.dart
diff --git a/dart/lib/compiler/implementation/ssa/codegen.dart b/dart/lib/compiler/implementation/ssa/codegen.dart
index bce5e56d4d1786f9fca48121b94504ef390e96cf..ca4d8bb4d4357f3ba711686cd2cb120a240e6cbd 100644
--- a/dart/lib/compiler/implementation/ssa/codegen.dart
+++ b/dart/lib/compiler/implementation/ssa/codegen.dart
@@ -1561,7 +1561,8 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
assert(superMethod.kind == ElementKind.GETTER);
String methodName =
compiler.namer.getterName(currentLibrary, superMethod.name);
- buffer.add('$className.prototype.$methodName.call(this)');
+ buffer.add('$className.prototype.$methodName.call');
+ visitArguments(node.inputs);
ngeoffray 2012/05/31 08:59:23 Don't we get just only one input (this) ?
ahe 2012/05/31 09:08:36 The input should be two things, the element and "t
ngeoffray 2012/05/31 09:37:07 Very good point. And doing the mistake looks quite
}
endExpression(JSPrecedence.CALL_PRECEDENCE);
world.registerStaticUse(superMethod);
« no previous file with comments | « no previous file | dart/tests/language/language.status » ('j') | dart/tests/language/language.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698