Issue 10451062: Add a browser configuration to avoid repeating (runtime == 'ff' || runtime == 'ie' || ...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10451062: Add a browser configuration to avoid repeating (runtime == 'ff' || runtime == 'ie' || ...). (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add a browser configuration to avoid repeating (runtime == 'ff' || runtime == 'ie' || ...). Committed: https://code.google.com/p/dart/source/detail?r=8035

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
M	dart/samples/tests/samples/samples.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/co19/co19-leg.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/standalone/standalone.status	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	dart/tools/testing/dart/test_options.dart	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10451062/diff/1/dart/tools/testing/dart/test_options.dart File dart/tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/10451062/diff/1/dart/tools/testing/dart/test_options.dart#newcode471 dart/tools/testing/dart/test_options.dart:471: if (runtime == 'firefox') configuration['runtime'] == 'ff'; I ...

8 years, 6 months ago (2012-05-29 07:38:31 UTC) #2

ngeoffray

8 years, 6 months ago (2012-05-29 07:39:21 UTC) #3

https://chromiumcodereview.appspot.com/10451062/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/test_options.dart (right):

https://chromiumcodereview.appspot.com/10451062/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/test_options.dart:471: if (runtime == 'firefox')
configuration['runtime'] == 'ff';
On 2012/05/29 07:38:31, kasperl wrote:
> I think the style in this file is to use { } and multiple lines for the then
> part of an if.

Done.

Expand Messages | Collapse Messages

Issue 10451062: Add a browser configuration to avoid repeating (runtime == 'ff' || runtime == 'ie' || ...). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages