Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: dart/tools/testing/dart/test_options.dart

Issue 10451062: Add a browser configuration to avoid repeating (runtime == 'ff' || runtime == 'ie' || ...). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/standalone/standalone.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_options.dart
===================================================================
--- dart/tools/testing/dart/test_options.dart (revision 8032)
+++ dart/tools/testing/dart/test_options.dart (working copy)
@@ -7,6 +7,7 @@
#import("dart:io");
#import("dart:builtin");
#import("drt_updater.dart");
+#import("test_suite.dart");
List<String> defaultTestSelectors =
const ['dartc', 'samples', 'standalone', 'corelib', 'co19', 'language',
@@ -466,10 +467,15 @@
configuration['unchecked'] = !configuration['checked'];
configuration['host_unchecked'] = !configuration['host_checked'];
- if (configuration['runtime'] == 'firefox') {
+ String runtime = configuration['runtime'];
+ if (runtime == 'firefox') {
configuration['runtime'] == 'ff';
}
+ if (TestUtils.isBrowserRuntime(runtime)) {
+ configuration['browser'] = true;
+ }
+
// Expand the test selectors into a suite name and a simple
// regular expressions to be used on the full path of a test file
// in that test suite. If no selectors are explicitly given use
« no previous file with comments | « dart/tests/standalone/standalone.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698