Issue 104503011: Small CL to change the way format is used for package versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104503011: Small CL to change the way format is used for package versions. (Closed)

Created:
7 years ago by Andrei Mouravski

Modified:
7 years ago

Reviewers:
Bob Nystrom, nweiz

Base URL:
https://github.com/dart-lang/pub-dartlang.git@master

Visibility:
Public.

More Reviews

Description

Small CL to change the way format is used for package versions. Adds tests to confirm new behaviour and old. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/8892da8

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
	M	app/handlers/api/package_versions.py	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
	M	test/test_handlers/api/test_package_versions.py	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://codereview.chromium.org/104503011/diff/1/app/handlers/api/package_versions.py File app/handlers/api/package_versions.py (right): https://codereview.chromium.org/104503011/diff/1/app/handlers/api/package_versions.py#newcode167 app/handlers/api/package_versions.py:167: def show(self, package_id, id, format=None): What does it mean ...

7 years ago (2013-12-18 19:24:00 UTC) #2

Andrei Mouravski

7 years ago (2013-12-19 21:27:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r8892da8 (presubmit successful).

Expand Messages | Collapse Messages

Issue 104503011: Small CL to change the way format is used for package versions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages