Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: test/test_handlers/api/test_package_versions.py

Issue 104503011: Small CL to change the way format is used for package versions. (Closed) Base URL: https://github.com/dart-lang/pub-dartlang.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/handlers/api/package_versions.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test_handlers/api/test_package_versions.py
diff --git a/test/test_handlers/api/test_package_versions.py b/test/test_handlers/api/test_package_versions.py
index 8338d5e56696be8c02a1402bf1bcced287e8a02a..b23c4d1981ecb951837f70b1774d801ce047fce0 100644
--- a/test/test_handlers/api/test_package_versions.py
+++ b/test/test_handlers/api/test_package_versions.py
@@ -253,6 +253,29 @@ class PackageVersionsTest(TestCase):
status=404)
self.assert_json_error(response)
+ def test_api_malformed_package_version(self):
+ version = self.package_version(self.package, '1.2.3')
+ version.put()
+
+ response = self.testapp.get(
+ '/api/packages/test-package/versions/banana', status=400)
+ self.assertEqual(response.headers['Content-Type'], 'application/json')
+ self.assertEqual(json.loads(response.body), {
+ 'error': {'message': '"banana" is not a valid semantic version.'}
+ })
+
+ def test_api_no_such_package_version(self):
+ version = self.package_version(self.package, '1.2.3')
+ version.put()
+
+ response = self.testapp.get(
+ '/api/packages/test-package/versions/2.0.0', status=404)
+ self.assertEqual(response.headers['Content-Type'], 'application/json')
+ self.assertEqual(json.loads(response.body), {
+ 'error':
+ {'message': '"test-package" version 2.0.0 doesn\'t exist.'}
+ })
+
def post_package_version(self, version, name='test-package'):
response = self.create_package(self.upload_archive(name, version))
self.assert_json_success(response)
« no previous file with comments | « app/handlers/api/package_versions.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698