Issue 10450016: Add a callback to inform embedders when an isolate is being shut down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10450016: Add a callback to inform embedders when an isolate is being shut down. (Closed)

Created:
8 years, 7 months ago by turnidge

Modified:
8 years, 5 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add a callback to inform embedders when an isolate is being shut down. Committed: https://code.google.com/p/dart/source/detail?r=9211

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -35 lines)			Patch
M	bin/gen_snapshot.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bin/main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bin/run_vm_tests.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/dart_api.h	View	3 chunks	+22 lines, -3 lines	0 comments	Download
M	vm/dart.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/dart.cc	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	vm/dart_api_impl.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1 chunk	+33 lines, -1 line	0 comments	Download
M	vm/isolate.h	View	2 chunks	+20 lines, -4 lines	0 comments	Download
M	vm/isolate.cc	View	1 chunk	+1 line, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

turnidge

Mads, I recall that you needed an isolate shutdown callback. Does this look like it ...

8 years, 7 months ago (2012-05-24 17:16:53 UTC) #1

Mads Ager (google)

8 years, 7 months ago (2012-05-25 05:47:03 UTC) #2

LGTM!

Yes, this would cover our needs. We have an event handler thread per isolate
that uses poll (the high-performance equivalent for the given platform) on a
bunch of file descriptors. This would allow us to stop those threads. Thanks!

Expand Messages | Collapse Messages