Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: vm/dart.cc

Issue 10450016: Add a callback to inform embedders when an isolate is being shut down. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart.h ('k') | vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart.cc
===================================================================
--- vm/dart.cc (revision 7933)
+++ vm/dart.cc (working copy)
@@ -30,7 +30,8 @@
// TODO(turnidge): We should add a corresponding Dart::Cleanup.
bool Dart::InitOnce(Dart_IsolateCreateCallback create,
- Dart_IsolateInterruptCallback interrupt) {
+ Dart_IsolateInterruptCallback interrupt,
+ Dart_IsolateShutdownCallback shutdown) {
// TODO(iposva): Fix race condition here.
if (vm_isolate_ != NULL || !Flags::Initialized()) {
return false;
@@ -59,6 +60,7 @@
Isolate::SetCurrent(NULL); // Unregister the VM isolate from this thread.
Isolate::SetCreateCallback(create);
Isolate::SetInterruptCallback(interrupt);
+ Isolate::SetShutdownCallback(shutdown);
return true;
}
@@ -112,8 +114,14 @@
void Dart::ShutdownIsolate() {
Isolate* isolate = Isolate::Current();
+ void* callback_data = isolate->init_callback_data();
isolate->Shutdown();
delete isolate;
+
+ Dart_IsolateShutdownCallback callback = Isolate::ShutdownCallback();
+ if (callback != NULL) {
+ (callback)(callback_data);
+ }
}
} // namespace dart
« no previous file with comments | « vm/dart.h ('k') | vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698