Address review comments in commited cl (issue 10460002).

Address review comments in commited cl (issue 10460002).
Committed: https://code.google.com/p/dart/source/detail?r=8144

[srdjan, 2012-05-30 17:19:43]

LGTM

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:1029: return i == 0 ? type_arguments() :
NULL;
InputCount can be two, but InputAt(1) is always NULL?  It is weird that the
receiver is input argument sometimes, but is not visible/referrable in the
CreateClosureComp. Any ideas how to solve it?

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:630: }
or you can say, Drop(2), else Drop(1) and removed the Drop above.

[regis, 2012-05-30 18:08:34]

Have another look, please.

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:1029: return i == 0 ? type_arguments() :
NULL;
On 2012/05/30 17:19:43, srdjan wrote:
> InputCount can be two, but InputAt(1) is always NULL?  It is weird that the
> receiver is input argument sometimes, but is not visible/referrable in the
> CreateClosureComp. Any ideas how to solve it?

I changed CreateClosureComp to be a TemplateComputation<2>. The receiver is now
always passed to the stub, as null if necessary.

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10448079/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:630: }
On 2012/05/30 17:19:43, srdjan wrote:
> or you can say, Drop(2), else Drop(1) and removed the Drop above.

Done.

[srdjan, 2012-05-30 18:17:47]

lgtm