Address review comments in commited cl (issue 10460002).

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "lib/error.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
@@ skipping 573 matching lines @@
   const intptr_t kNumTemps = 1;
   LocationSummary* locs = new LocationSummary(kNumInputs, kNumTemps);
   locs->set_in(0, Location::RegisterLocation(RBX));
   locs->set_temp(0, Location::RegisterLocation(R10));
   locs->set_out(Location::RegisterLocation(RAX));
   return locs;
 }
 
 
 void CreateArrayComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  ASSERT(locs()->in(0).reg() == RBX);
-  ASSERT(locs()->temp(0).reg() == R10);
+  Register temp_reg = locs()->temp(0).reg();
+  Register result_reg = locs()->out().reg();
 
   // 1. Allocate the array.  R10 = length, RBX = element type.
-  __ movq(R10, Immediate(Smi::RawValue(ElementCount())));
+  ASSERT(temp_reg == R10);
+  ASSERT(locs()->in(0).reg() == RBX);
+  __ movq(temp_reg, Immediate(Smi::RawValue(ElementCount())));
   compiler->GenerateCall(token_index(),
                          try_index(),
                          &StubCode::AllocateArrayLabel(),
                          PcDescriptors::kOther);
 
-  // 2. Initialize the array in RAX with the element values.
-  __ leaq(R10, FieldAddress(RAX, Array::data_offset()));
+  // 2. Initialize the array in result_reg with the element values.
+  __ leaq(temp_reg, FieldAddress(result_reg, Array::data_offset()));
   for (int i = ElementCount() - 1; i >= 0; --i) {
-    if (ElementAt(i)->IsUse()) {
-      __ popq(Address(R10, i * kWordSize));
-    } else {
-      compiler->LoadValue(RBX, ElementAt(i));
-      __ movq(Address(R10, i * kWordSize), RBX);
-    }
+    ASSERT(ElementAt(i)->IsUse());
+    __ popq(Address(temp_reg, i * kWordSize));
   }
 }
 
 
 LocationSummary* CreateClosureComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void CreateClosureComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   const Function& closure_function = function();
   const Code& stub = Code::Handle(
       StubCode::GetAllocationStubForClosure(closure_function));
   const ExternalLabel label(closure_function.ToCString(), stub.EntryPoint());
   compiler->GenerateCall(token_index(), try_index(), &label,
                          PcDescriptors::kOther);
-
-  const Class& cls = Class::Handle(closure_function.signature_class());
-  if (cls.HasTypeArguments()) {
-    __ Drop(1);  // Discard type arguments.
-  }
+  __ Drop(1);  // Discard type arguments.
   if (closure_function.IsImplicitInstanceClosureFunction()) {
     __ Drop(1);  // Discard receiver.
   }

[srdjan, 2012/05/30 17:19:43]

or you can say, Drop(2), else Drop(1) and removed the Drop above.

[regis, 2012/05/30 18:08:34]

Done.

 }
 
 
 LocationSummary* AllocateObjectComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void AllocateObjectComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   const Class& cls = Class::ZoneHandle(constructor().owner());
@@ skipping 416 matching lines @@
   if (locs()->out().reg() != RAX) {
     __ movq(locs()->out().reg(), RAX);
   }
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64