fix for index operation unparses

fix for:
1) "list[0] = 1" unparses to "list[] = 0 1";
2) "a = list[0]" unparses to "a = list[][0]";


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8142

[Anton Muhin, 2012-05-24 16:59:58]

https://chromiumcodereview.appspot.com/10448008/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10448008/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:215: bool isListIndex = op !==
null && op.source.stringValue == '[]';
I believe we have exactly the same problem for expressions like l[0], e.g. var x
= l[0].  So solution should be in unparseSendPart

[Roman, 2012-05-30 09:09:55]

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:207: NodeList tailArguments = new
NodeList(
not sure about this one. beginToken and endToken would be incorrect, but we need
to unparse the rest of arguments.

[ahe, 2012-05-30 10:03:11]

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:200: // Special case for
assignments like "list[0] = 1".
This should be a doc comment.

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:201: visitListIndexSet(SendSet
node) {
This is not a visitor method. So it should be named for it it does. For example:

unparseIndexedSet

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:207: NodeList tailArguments = new
NodeList(
On 2012/05/30 09:09:55, Roman wrote:
> not sure about this one. beginToken and endToken would be incorrect, but we
need
> to unparse the rest of arguments.

I don't like constructing fake AST nodes just for unparsing. How about:

String delimiter = (node.argumentsNode.delimiter === null) ? " " :
"${node.argumentsNode.delimiter} ";

node.argumentsNode.nodes.tail.printOn(sb, delimiter);

You could possibly share this with visitNodeList.

[Roman, 2012-05-30 10:44:04]

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:200: // Special case for
assignments like "list[0] = 1".
On 2012/05/30 10:03:12, ahe wrote:
> This should be a doc comment.

Done.

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:201: visitListIndexSet(SendSet
node) {
On 2012/05/30 10:03:12, ahe wrote:
> This is not a visitor method. So it should be named for it it does. For
example:
> 
> unparseIndexedSet

Done.

https://chromiumcodereview.appspot.com/10448008/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:207: NodeList tailArguments = new
NodeList(
On 2012/05/30 10:03:12, ahe wrote:
> On 2012/05/30 09:09:55, Roman wrote:
> > not sure about this one. beginToken and endToken would be incorrect, but we
> need
> > to unparse the rest of arguments.
> 
> I don't like constructing fake AST nodes just for unparsing. How about:
> 
> String delimiter = (node.argumentsNode.delimiter === null) ? " " :
> "${node.argumentsNode.delimiter} ";
> 
> node.argumentsNode.nodes.tail.printOn(sb, delimiter);
> 
> You could possibly share this with visitNodeList.

Done.

[ahe, 2012-05-30 10:59:22]

LGTM!

[Roman, 2012-05-30 11:03:33]

On 2012/05/30 10:59:22, ahe wrote:
> LGTM!

Thank you for the quick review! Committing my first CL now.