fix for index operation unparses

lib/compiler/implementation/tree/unparser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Unparser implements Visitor {
   StringBuffer sb;
   final bool printDebugInfo;
 
   Unparser([this.printDebugInfo = false]);
 
@@ skipping 161 matching lines @@
 
   visitReturn(Return node) {
     add(node.beginToken.value);
     if (node.hasExpression) {
       sb.add(' ');
       visit(node.expression);
     }
     if (node.endToken !== null) add(node.endToken.value);
   }
 
-
   unparseSendPart(Send node) {
     if (node.isPrefix) {
       visit(node.selector);
     }
     if (node.receiver !== null) {
       visit(node.receiver);
       if (node.selector is !Operator) sb.add('.');
     }
-    if (!node.isPrefix) {
+    if (!node.isPrefix && !node.isIndex) {
       visit(node.selector);
     }
   }
 
   visitSend(Send node) {
     unparseSendPart(node);
     visit(node.argumentsNode);
   }
 
+  // Special case for assignments like "list[0] = 1".

[ahe, 2012/05/30 10:03:12]

This should be a doc comment.

[Roman, 2012/05/30 10:44:04]

Done.

+  visitListIndexSet(SendSet node) {

[ahe, 2012/05/30 10:03:12]

This is not a visitor method. So it should be named for it it does. For example:

unparseIndexedSet

[Roman, 2012/05/30 10:44:04]

Done.

+    visit(node.receiver);
+    sb.add('[');
+    sb.add(node.arguments.head);
+    sb.add(']');
+    add(node.assignmentOperator.token.value);
+    NodeList tailArguments = new NodeList(

[Roman, 2012/05/30 09:09:55]

not sure about this one. beginToken and endToken would be incorrect, but we need
to unparse the rest of arguments.

[ahe, 2012/05/30 10:03:12]

I don't like constructing fake AST nodes just for unparsing. How about:

String delimiter = (node.argumentsNode.delimiter === null) ? " " :
"${node.argumentsNode.delimiter} ";

node.argumentsNode.nodes.tail.printOn(sb, delimiter);

You could possibly share this with visitNodeList.

[Roman, 2012/05/30 10:44:04]

Done.

+        node.argumentsNode.beginToken, node.argumentsNode.nodes.tail,
+        node.argumentsNode.endToken, node.argumentsNode.delimiter);
+    visit(tailArguments);
+  }
+
   visitSendSet(SendSet node) {
-    unparseSendPart(node);
-    add(node.assignmentOperator.token.value);
-    visit(node.argumentsNode);
+    if (node.isIndex) {
+      visitListIndexSet(node);
+    } else {
+      unparseSendPart(node);
+      add(node.assignmentOperator.token.value);
+      visit(node.argumentsNode);
+    }
   }
 
   visitThrow(Throw node) {
     add(node.throwToken.value);
     if (node.expression !== null) {
       sb.add(' ');
       visit(node.expression);
     }
     node.endToken.value.printOn(sb);
   }
@@ skipping 188 matching lines @@
       sb.add(' ');
     }
     visit(node.name);
     if (node.typeParameters !== null) {
       visit(node.typeParameters);
     }
     visit(node.formals);
     add(node.endToken.value);
   }
 }