Issue 10446019: - Port AssertBool and AssertAssigneable to new location template.

Issue 10446019: - Port AssertBool and AssertAssigneable to new location template. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
Florian Schneider, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Port AssertBool and AssertAssigneable to new location template. - Change AssertAssigneable to always have instantiator and instantiator-type-arguments (if only as a null literal). Committed: https://code.google.com/p/dart/source/detail?r=7962

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -86 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	3 chunks	+12 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+4 lines, -37 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1	3 chunks	+8 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+12 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+40 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/flow_graph_builder.cc#newcode584 runtime/vm/flow_graph_builder.cc:584: // instantiator_type_arguments are on TOS, instantiator is at ...

8 years, 7 months ago (2012-05-24 19:56:18 UTC) #2

Florian Schneider

LGTM. https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/intermediate_language_x64.cc#newcode232 runtime/vm/intermediate_language_x64.cc:232: summary->set_out(Location::RegisterLocation(RAX)); I'm not sure which is preferable, but ...

8 years, 7 months ago (2012-05-24 20:04:57 UTC) #3

srdjan

https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10446019/diff/1/runtime/vm/flow_graph_builder.cc#newcode584 runtime/vm/flow_graph_builder.cc:584: // instantiator_type_arguments are on TOS, instantiator is at TOS ...

8 years, 7 months ago (2012-05-24 20:24:44 UTC) #4

Expand Messages | Collapse Messages