Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 10446019: - Port AssertBool and AssertAssigneable to new location template. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 7960)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -658,47 +658,14 @@
void FlowGraphCompiler::VisitAssertAssignable(AssertAssignableComp* comp) {
- const Immediate raw_null =
- Immediate(reinterpret_cast<intptr_t>(Object::null()));
- if (comp->instantiator_type_arguments() == NULL) {
- __ movq(RDX, raw_null);
- } else {
- LoadValue(RDX, comp->instantiator_type_arguments());
- }
- if (comp->instantiator() == NULL) {
- __ movq(RCX, raw_null);
- } else {
- LoadValue(RCX, comp->instantiator());
- }
- LoadValue(RAX, comp->value());
- GenerateAssertAssignable(comp->cid(),
- comp->token_index(),
- comp->try_index(),
- comp->dst_type(),
- comp->dst_name());
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
void FlowGraphCompiler::VisitAssertBoolean(AssertBooleanComp* comp) {
- LoadValue(RAX, comp->value());
- // Check that the type of the value is allowed in conditional context.
- // Call the runtime if the object is not bool::true or bool::false.
- Label done;
- __ CompareObject(RAX, Bool::ZoneHandle(Bool::True()));
- __ j(EQUAL, &done, Assembler::kNearJump);
- __ CompareObject(RAX, Bool::ZoneHandle(Bool::False()));
- __ j(EQUAL, &done, Assembler::kNearJump);
-
- __ pushq(Immediate(Smi::RawValue(comp->token_index()))); // Source location.
- __ pushq(RAX); // Push the source object.
- GenerateCallRuntime(comp->cid(),
- comp->token_index(),
- comp->try_index(),
- kConditionTypeErrorRuntimeEntry);
- // We should never return here.
- __ int3();
-
- __ Bind(&done);
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698