Issue 10443036: Fix typo in webdriver test setup script.

Issue 10443036: Fix typo in webdriver test setup script. (Closed)

Created:
8 years, 7 months ago by Emily Fortuna

Modified:
8 years, 7 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix typo in webdriver test setup script. Committed: https://code.google.com/p/dart/source/detail?r=8023

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	tools/testing/perf_testing/run_perf_tests.py	View	1 2	3 chunks	+8 lines, -2 lines	0 comments	Download
	M	tools/testing/webdriver_test_setup.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/10443036/diff/2001/samples/third_party/dromaeo/tests/dom-query.dart File samples/third_party/dromaeo/tests/dom-query.dart (right): https://chromiumcodereview.appspot.com/10443036/diff/2001/samples/third_party/dromaeo/tests/dom-query.dart#newcode31 samples/third_party/dromaeo/tests/dom-query.dart:31: .test('getElementsByTagName(*)', () { These edits were left from when ...

8 years, 7 months ago (2012-05-25 18:10:31 UTC) #1

Emily Fortuna

https://chromiumcodereview.appspot.com/10443036/diff/4001/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/10443036/diff/4001/tools/testing/perf_testing/run_perf_tests.py#newcode953 tools/testing/perf_testing/run_perf_tests.py:953: if platform.system() == 'Windows': For whatever reason, quotes was ...

8 years, 7 months ago (2012-05-25 18:27:34 UTC) #2

vsm

8 years, 7 months ago (2012-05-25 19:20:04 UTC) #3

Please revert the dom_query.dart change.  Otherwise, LGTM.

https://chromiumcodereview.appspot.com/10443036/diff/4001/samples/third_party...
File samples/third_party/dromaeo/tests/dom-query.dart (right):

https://chromiumcodereview.appspot.com/10443036/diff/4001/samples/third_party...
samples/third_party/dromaeo/tests/dom-query.dart:48: }
This look some old debug code - possibly mine - please revert.

Expand Messages | Collapse Messages