Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10443036: Fix typo in webdriver test setup script. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 8007)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -827,7 +827,9 @@
"""Runs Dromaeo tests, in the browser."""
def __init__(self, test_runner):
super(DromaeoTest, self).__init__(
- self.name(), BrowserTester.get_browsers(), 'browser',
+ self.name(),
+ filter(lambda x: x != 'ie', BrowserTester.get_browsers()),
+ 'browser',
DromaeoTester.get_dromaeo_versions(),
DromaeoTester.get_dromaeo_benchmarks(), test_runner,
self.DromaeoPerfTester(self),
@@ -935,7 +937,7 @@
versions = DromaeoTester.get_dromaeo_versions()
- for browser in BrowserTester.get_browsers():
+ for browser in filter(lambda x: x != 'ie', BrowserTester.get_browsers()):
self.move_chrome_driver_if_needed(browser)
for version_name in versions:
if not self.test.is_valid_combination(browser, version_name):
@@ -948,6 +950,10 @@
self.add_svn_revision_to_trace(self.test.trace_file, browser)
file_path = '"%s"' % os.path.join(os.getcwd(), dromaeo_path,
'index-js.html?%s' % version)
+ if platform.system() == 'Windows':
+ file_path = file_path.replace('&', '^&')
+ file_path = file_path.replace('?', '^?')
+ file_path = file_path.replace('|', '^|')
self.test.test_runner.run_cmd(
['python', os.path.join('tools', 'testing', 'run_selenium.py'),
'--out', file_path, '--browser', browser,
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698