Issue 10433003: Make Dart_GetClass work for private classes.

Issue 10433003: Make Dart_GetClass work for private classes. (Closed)

Created:
8 years, 7 months ago by turnidge

Modified:
8 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Make Dart_GetClass work for private classes. Committed: https://code.google.com/p/dart/source/detail?r=7926

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -19 lines)			Patch
M	include/dart_api.h	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1	3 chunks	+18 lines, -11 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1	1 chunk	+33 lines, -4 lines	0 comments	Download
M	vm/object.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	vm/object.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM https://chromiumcodereview.appspot.com/10433003/diff/1/include/dart_api.h File include/dart_api.h (right): https://chromiumcodereview.appspot.com/10433003/diff/1/include/dart_api.h#newcode2044 include/dart_api.h:2044: * \return If no error occurs, the Library ...

8 years, 7 months ago (2012-05-23 20:59:06 UTC) #2

turnidge

8 years, 7 months ago (2012-05-23 21:44:50 UTC) #3

https://chromiumcodereview.appspot.com/10433003/diff/1/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10433003/diff/1/include/dart_api.h#new...
include/dart_api.h:2044: * \return If no error occurs, the Library is returned.
Otherwise an
On 2012/05/23 20:59:06, asiva wrote:
> the class or interface is returned.

Done.

https://chromiumcodereview.appspot.com/10433003/diff/1/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10433003/diff/1/vm/object.h#newcode1740
vm/object.h:1740: RawClass* LookupClassAllowPrivate(const String& name) const;
On 2012/05/23 20:59:06, asiva wrote:
> I am wondering if we should just have
> RawClass* LookupPrivateClass(const String& name) const;
> here instead of the combo and Dart_GetClass could first
> call LookupClass(..);
> if this returns null it could then  call LookupPrivateClass(...);

Discussed offline.  I am adding a TODO(turnidge) to go through these functions
and make them more consistent.

Expand Messages | Collapse Messages