Make Dart_GetClass work for private classes.

vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 2593 matching lines @@
     }
 
     // Invoke the getter and return the result.
     GrowableArray<const Object*> args;
     const Array& kNoArgNames = Array::Handle(isolate);
     return Api::NewHandle(
         isolate,
         DartEntry::InvokeDynamic(instance, getter, args, kNoArgNames));
 
   } else if (obj.IsClass()) {
+    // Finalize all classes.
+    const char* msg = CheckIsolateState(isolate);
+    if (msg != NULL) {
+      return Api::NewError(msg);
+    }
     // To access a static field we may need to use the Field or the
     // getter Function.
     Class& cls = Class::Handle(isolate);
     cls ^= obj.raw();
     field = cls.LookupStaticField(field_name);
     if (field.IsNull() || FieldIsUninitialized(isolate, field)) {
       const String& getter_name =
           String::Handle(isolate, Field::GetterName(field_name));
       getter = cls.LookupStaticFunction(getter_name);
     }
 
     if (!getter.IsNull()) {
       // Invoke the getter and return the result.
       GrowableArray<const Object*> args;
       const Array& kNoArgNames = Array::Handle(isolate);
       return Api::NewHandle(
           isolate, DartEntry::InvokeStatic(getter, args, kNoArgNames));
     } else if (!field.IsNull()) {
       return Api::NewHandle(isolate, field.value());
     } else {
       return Api::NewError("%s: did not find static field '%s'.",
                            CURRENT_FUNC, field_name.ToCString());
     }
 
   } else if (obj.IsLibrary()) {
+    // TODO(turnidge): Do we need to call CheckIsolateState here?
+
     // To access a top-level we may need to use the Field or the
     // getter Function.  The getter function may either be in the
     // library or in the field's owner class, depending.
     Library& lib = Library::Handle(isolate);
     lib ^= obj.raw();
     field = lib.LookupFieldAllowPrivate(field_name);
     if (field.IsNull()) {
       // No field found.  Check for a getter in the lib.
       const String& getter_name =
           String::Handle(isolate, Field::GetterName(field_name));
@@ skipping 468 matching lines @@
   CompileAll(isolate, &result);
   return result;
 }
 
 
 DART_EXPORT bool Dart_IsLibrary(Dart_Handle object) {
   return Api::ClassIndex(object) == kLibrary;
 }
 
 
-DART_EXPORT Dart_Handle Dart_GetClass(Dart_Handle library, Dart_Handle name) {
+DART_EXPORT Dart_Handle Dart_GetClass(Dart_Handle library,
+                                      Dart_Handle class_name) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Object& param = Object::Handle(isolate, Api::UnwrapHandle(name));
-  if (param.IsNull() || !param.IsString()) {
-    return Api::NewError("Invalid class name specified");
+  const Library& lib = Api::UnwrapLibraryHandle(isolate, library);
+  if (lib.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, library, Library);
   }
-  const Library& lib =
-      Library::CheckedHandle(isolate, Api::UnwrapHandle(library));
-  if (lib.IsNull()) {
-    return Api::NewError("Invalid parameter, Unknown library specified");
+  const String& cls_name = Api::UnwrapStringHandle(isolate, class_name);
+  if (cls_name.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, class_name, String);
   }
-  String& cls_name = String::Handle(isolate);
-  cls_name ^= param.raw();
-  const Class& cls = Class::Handle(isolate, lib.LookupClass(cls_name));
+  const Class& cls =
+      Class::Handle(isolate, lib.LookupClassAllowPrivate(cls_name));
   if (cls.IsNull()) {
+    // TODO(turnidge): Return null or error in this case?
     const String& lib_name = String::Handle(isolate, lib.name());
     return Api::NewError("Class '%s' not found in library '%s'.",
                          cls_name.ToCString(), lib_name.ToCString());
   }
   return Api::NewHandle(isolate, cls.raw());
 }
 
 
 DART_EXPORT Dart_Handle Dart_LibraryUrl(Dart_Handle library) {
   Isolate* isolate = Isolate::Current();
@@ skipping 153 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart