Issue 10416031: Convert CurrentContext and StoreContext to locations code generation scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416031: Convert CurrentContext and StoreContext to locations code generation scheme (Closed)

Created:
8 years, 7 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert CurrentContext and StoreContext to locations code generation scheme R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7869

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -47 lines)			Patch
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+21 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+16 lines, -43 lines	2 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10416031/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10416031/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode31 runtime/vm/intermediate_language_ia32.cc:31: DEFINE_UNIMPLEMENTED(StoreContextComp) All those need toi be Bailouts. Maybe ...

8 years, 7 months ago (2012-05-22 16:56:22 UTC) #2

Vyacheslav Egorov (Google)

8 years, 7 months ago (2012-05-22 18:40:13 UTC) #3

Thanks for the review. Landed.

https://chromiumcodereview.appspot.com/10416031/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10416031/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:31:
DEFINE_UNIMPLEMENTED(StoreContextComp)
On 2012/05/22 16:56:22, srdjan wrote:
> All those need toi be Bailouts. Maybe next CL.

It's a logical error to call EmitNativeCode if locs() == NULL, so I don't think
it should be bailout.

And MakeLocationSummary can't bailout because it does not have FlowGraphCompiler
(which has Bailout method).

I suggest the following approach for another CL: remove unimplemented from
MakeLocationSummary and let it return NULL. Then add Bailout at "driver loop"
level: e.g. pseudocode

if (instr->locs() == NULL) Bailout("unsupported instruction %s",
instr->mnemonic());

What do you think?

Expand Messages | Collapse Messages