Convert CurrentContext and StoreContext to locations code generation scheme

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
 
 #define __ compiler->assembler()->
 
 namespace dart {
 
 
-LocationSummary* StrictCompareComp::MakeLocationSummary() {
-  UNIMPLEMENTED();
-  return NULL;
-}
+#define DEFINE_UNIMPLEMENTED(name)                            \
+  LocationSummary* name::MakeLocationSummary() {              \
+    UNIMPLEMENTED();                                          \
+    return NULL;                                              \
+  }                                                           \
+                                                              \
+  void name::EmitNativeCode(FlowGraphCompiler* compiler) {    \
+    UNIMPLEMENTED();                                          \
+  }
 
-
-void StrictCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  UNIMPLEMENTED();
-}
-
+DEFINE_UNIMPLEMENTED(StrictCompareComp)
+DEFINE_UNIMPLEMENTED(ClosureCallComp)
+DEFINE_UNIMPLEMENTED(InstanceCallComp)
+DEFINE_UNIMPLEMENTED(StaticCallComp)
+DEFINE_UNIMPLEMENTED(CurrentContextComp)
+DEFINE_UNIMPLEMENTED(StoreContextComp)

[srdjan, 2012/05/22 16:56:22]

All those need toi be Bailouts. Maybe next CL.

[Vyacheslav Egorov (Google), 2012/05/22 18:40:14]

It's a logical error to call EmitNativeCode if locs() == NULL, so I don't think
it should be bailout.

And MakeLocationSummary can't bailout because it does not have FlowGraphCompiler
(which has Bailout method).

I suggest the following approach for another CL: remove unimplemented from
MakeLocationSummary and let it return NULL. Then add Bailout at "driver loop"
level: e.g. pseudocode

if (instr->locs() == NULL) Bailout("unsupported instruction %s",
instr->mnemonic());

What do you think?

 
 void BindInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   UNIMPLEMENTED();
 }
 
 
-LocationSummary* ClosureCallComp::MakeLocationSummary() {
-  UNIMPLEMENTED();
-  return NULL;
-}
-
-
-void ClosureCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  UNIMPLEMENTED();
-}
-
-
-LocationSummary* InstanceCallComp::MakeLocationSummary() {
-  UNIMPLEMENTED();
-  return NULL;
-}
-
-
-void InstanceCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  UNIMPLEMENTED();
-}
-
-
-LocationSummary* StaticCallComp::MakeLocationSummary() {
-  UNIMPLEMENTED();
-  return NULL;
-}
-
-
-void StaticCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  UNIMPLEMENTED();
-}
-
-
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64