Issue 10413028: Also use the redirecting name in stubs for native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413028: Also use the redirecting name in stubs for native methods. (Closed)

Created:
8 years, 7 months ago by ngeoffray

Modified:
8 years, 7 months ago

Reviewers:
floitsch, sra1

CC:
reviews_dartlang.org, kasperl, karlklose, ahe, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Also use the redirecting name in stubs for native methods. Committed: https://code.google.com/p/dart/source/detail?r=7789

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
M	lib/compiler/implementation/native_emitter.dart	View	1	3 chunks	+11 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/html.status	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10413028/diff/1/lib/compiler/implementation/native_emitter.dart File lib/compiler/implementation/native_emitter.dart (right): https://chromiumcodereview.appspot.com/10413028/diff/1/lib/compiler/implementation/native_emitter.dart#newcode32 lib/compiler/implementation/native_emitter.dart:32: // Caches the methods that redirects to a ...

8 years, 7 months ago (2012-05-21 10:45:01 UTC) #2

ngeoffray

8 years, 7 months ago (2012-05-21 10:47:19 UTC) #3

Thanks Florian

https://chromiumcodereview.appspot.com/10413028/diff/1/lib/compiler/implement...
File lib/compiler/implementation/native_emitter.dart (right):

https://chromiumcodereview.appspot.com/10413028/diff/1/lib/compiler/implement...
lib/compiler/implementation/native_emitter.dart:32: // Caches the methods that
redirects to a JS method.
On 2012/05/21 10:45:01, floitsch wrote:
> redirect

Done.

Expand Messages | Collapse Messages

Issue 10413028: Also use the redirecting name in stubs for native methods. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages