Make it less verbose to declare instructions that use LocationSummary-based code generation.

This should avoid duplicating too much boilerplate code.
Committed: https://code.google.com/p/dart/source/detail?r=7884

[Ivan Posva, 2012-05-22 22:19:49]

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:116: // TODO(vegorov): This should be pure virtual
method.
This comment is out of date, as it should just be an accessor to the locs_
field.

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:126: virtual LocationSummary* MakeLocationSummary()
const {
This one here and the one below should be pure virtual.

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:257: virtual LocationSummary* MakeLocationSummary()
const;                        \
Then these two can just move into the general macro. And the .cc files will have
to have empty implementations for all instructions. => No boilerplate in the
future as we port.

[Florian Schneider, 2012-05-22 23:01:06]

Addressed comments.

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:116: // TODO(vegorov): This should be pure virtual
method.
On 2012/05/22 22:19:49, Ivan Posva wrote:
> This comment is out of date, as it should just be an accessor to the locs_
> field.

Done.

https://chromiumcodereview.appspot.com/10412043/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:126: virtual LocationSummary* MakeLocationSummary()
const {
On 2012/05/22 22:19:49, Ivan Posva wrote:
> This one here and the one below should be pure virtual.

Done.

[Ivan Posva, 2012-05-22 23:36:06]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
vm/intermediate_language.h:116: if (locs_ == NULL) locs_ =
MakeLocationSummary();
Where are the {}s?

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
vm/intermediate_language.h:125: virtual void EmitNativeCode(FlowGraphCompiler*
compiler) = 0;
Can this be const?

[srdjan, 2012-05-22 23:46:14]

LGTM

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
File vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
vm/intermediate_language_x64.cc:211: void
UseVal::EmitNativeCode(FlowGraphCompiler* compiler) {
UNREACHABLE or UNIMPLEMENTED ?

[Florian Schneider, 2012-05-23 00:02:01]

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
vm/intermediate_language.h:116: if (locs_ == NULL) locs_ =
MakeLocationSummary();
On 2012/05/22 23:36:07, Ivan Posva wrote:
> Where are the {}s?

Done.

https://chromiumcodereview.appspot.com/10412043/diff/5001/vm/intermediate_lan...
vm/intermediate_language.h:125: virtual void EmitNativeCode(FlowGraphCompiler*
compiler) = 0;
On 2012/05/22 23:36:07, Ivan Posva wrote:
> Can this be const?

Not yet. locs() needs to be const as well for that.