Make it less verbose to declare instructions that use LocationSummary-based code generation.

vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
 #include "vm/stub_code.h"
@@ skipping 28 matching lines @@
     intptr_t input_count, Location out) {
   LocationSummary* summary = new LocationSummary(input_count);
   for (intptr_t i = 0; i < input_count; i++) {
     summary->set_in(i, Location::RequiresRegister());
   }
   summary->set_out(out);
   return summary;
 }
 
 
-LocationSummary* CurrentContextComp::MakeLocationSummary() {
+LocationSummary* CurrentContextComp::MakeLocationSummary() const {
   return MakeSimpleLocationSummary(0, Location::RequiresRegister());
 }
 
 
 void CurrentContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   __ movq(locs()->out().reg(), CTX);
 }
 
 
-LocationSummary* StoreContextComp::MakeLocationSummary() {
+LocationSummary* StoreContextComp::MakeLocationSummary() const {
   LocationSummary* summary = new LocationSummary(1);
   summary->set_in(0, Location::RegisterLocation(CTX));
   return summary;
 }
 
 
 void StoreContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   // Nothing to do.  Context register were loaded by register allocator.
   ASSERT(locs()->in(0).reg() == CTX);
 }
 
 
-LocationSummary* StrictCompareComp::MakeLocationSummary() {
+LocationSummary* StrictCompareComp::MakeLocationSummary() const {
   return MakeSimpleLocationSummary(2, Location::SameAsFirstInput());
 }
 
 
 void StrictCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   const Bool& bool_true = Bool::ZoneHandle(Bool::True());
   const Bool& bool_false = Bool::ZoneHandle(Bool::False());
 
   Register left = locs()->in(0).reg();
   Register right = locs()->in(1).reg();
@@ skipping 16 matching lines @@
 
 // Generic summary for call instructions that have all arguments pushed
 // on the stack and return the result in a fixed register RAX.
 static LocationSummary* MakeCallSummary() {
   LocationSummary* result = new LocationSummary(0);
   result->set_out(Location::RegisterLocation(RAX));
   return result;
 }
 
 
-LocationSummary* ClosureCallComp::MakeLocationSummary() {
+LocationSummary* ClosureCallComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void ClosureCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   ASSERT(VerifyCallComputation(this));
   // The arguments to the stub include the closure.  The arguments
   // descriptor describes the closure's arguments (and so does not include
   // the closure).
   int argument_count = ArgumentCount();
   const Array& arguments_descriptor =
       CodeGenerator::ArgumentsDescriptor(argument_count - 1,
                                          argument_names());
   __ LoadObject(R10, arguments_descriptor);
 
   compiler->GenerateCall(token_index(),
                          try_index(),
                          &StubCode::CallClosureFunctionLabel(),
                          PcDescriptors::kOther);
   __ Drop(argument_count);
 }
 
 
-LocationSummary* InstanceCallComp::MakeLocationSummary() {
+LocationSummary* InstanceCallComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void InstanceCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   ASSERT(VerifyCallComputation(this));
   compiler->EmitInstanceCall(cid(),
                              token_index(),
                              try_index(),
                              function_name(),
                              ArgumentCount(),
                              argument_names(),
                              checked_argument_count());
 }
 
 
-LocationSummary* StaticCallComp::MakeLocationSummary() {
+LocationSummary* StaticCallComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void StaticCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   ASSERT(VerifyCallComputation(this));
   compiler->EmitStaticCall(token_index(),
                            try_index(),
                            function(),
                            ArgumentCount(),
                            argument_names());
 }
 
 
-LocationSummary* LoadLocalComp::MakeLocationSummary() {
+LocationSummary* LoadLocalComp::MakeLocationSummary() const {
   return MakeSimpleLocationSummary(0, Location::RequiresRegister());
 }
 
 
 void LoadLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register result = locs()->out().reg();
   __ movq(result, Address(RBP, local().index() * kWordSize));
 }
 
 
-LocationSummary* StoreLocalComp::MakeLocationSummary() {
+LocationSummary* StoreLocalComp::MakeLocationSummary() const {
   return MakeSimpleLocationSummary(1, Location::SameAsFirstInput());
 }
 
 
 void StoreLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register value = locs()->in(0).reg();
   Register result = locs()->out().reg();
   ASSERT(result == value);  // Assert that register assignment is correct.
   __ movq(Address(RBP, local().index() * kWordSize), value);
 }
 
 
 void BindInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   computation()->EmitNativeCode(compiler);
   __ pushq(locs()->out().reg());
 }
 
 
-LocationSummary* ConstantVal::MakeLocationSummary() {
+LocationSummary* ConstantVal::MakeLocationSummary() const {
   return MakeSimpleLocationSummary(0, Location::RequiresRegister());
 }
 
 
 void ConstantVal::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register result = locs()->out().reg();
   if (value().IsSmi()) {
     int64_t imm = reinterpret_cast<int64_t>(value().raw());
     __ movq(result, Immediate(imm));
   } else {
     __ LoadObject(result, value());
   }
 }
 
 
+void UseVal::EmitNativeCode(FlowGraphCompiler* compiler) {

[srdjan, 2012/05/22 23:46:14]

UNREACHABLE or UNIMPLEMENTED ?

+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* UseVal::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void AssertAssignableComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* AssertAssignableComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void AssertBooleanComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* AssertBooleanComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void EqualityCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* EqualityCompareComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void NativeCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* NativeCallComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void StoreIndexedComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* StoreIndexedComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void InstanceSetterComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* InstanceSetterComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void StaticSetterComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* StaticSetterComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void LoadInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* LoadInstanceFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void StoreInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* StoreInstanceFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void LoadStaticFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* LoadStaticFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void StoreStaticFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* StoreStaticFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void BooleanNegateComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* BooleanNegateComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void InstanceOfComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* InstanceOfComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void CreateArrayComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* CreateArrayComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void CreateClosureComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* CreateClosureComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void AllocateObjectComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* AllocateObjectComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void AllocateObjectWithBoundsCheckComp::EmitNativeCode(
+    FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* AllocateObjectWithBoundsCheckComp::
+    MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void NativeLoadFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* NativeLoadFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void NativeStoreFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* NativeStoreFieldComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void InstantiateTypeArgumentsComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* InstantiateTypeArgumentsComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void ExtractConstructorTypeArgumentsComp::EmitNativeCode(
+    FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* ExtractConstructorTypeArgumentsComp::
+    MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void ExtractConstructorInstantiatorComp::EmitNativeCode(
+    FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* ExtractConstructorInstantiatorComp::
+    MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void AllocateContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* AllocateContextComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void ChainContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* ChainContextComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void CloneContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* CloneContextComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
+void CatchEntryComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  UNIMPLEMENTED();
+}
+
+
+LocationSummary* CatchEntryComp::MakeLocationSummary() const {
+  return NULL;
+}
+
+
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64