Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10409043: Make saving and restoring of the context around closure calls explicit. (Closed)

Created:
8 years, 7 months ago by Florian Schneider
Modified:
8 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make saving and restoring of the context around closure calls explicit. This is a first step to refactor the codegen-templates to be reused between optimizing and non-optimizing backend. The context is now explicitly saved in a temporary local variable and not passed as an argument to the ClosureCall instruction anymore. Committed: https://code.google.com/p/dart/source/detail?r=7811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M vm/flow_graph_builder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M vm/flow_graph_builder.cc View 2 chunks +27 lines, -12 lines 0 comments Download
M vm/flow_graph_compiler_x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M vm/il_printer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/intermediate_language.h View 2 chunks +2 lines, -12 lines 0 comments Download
M vm/intermediate_language.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/parser.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 7 months ago (2012-05-19 03:18:50 UTC) #1
srdjan
8 years, 7 months ago (2012-05-21 17:43:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698