vm/flow_graph_compiler_x64.cc - Issue 10409043: Make saving and restoring of the context around closure calls explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10409043: Make saving and restoring of the context around closure calls explicit. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/flow_graph_compiler_x64.cc

===================================================================

--- vm/flow_graph_compiler_x64.cc (revision 7782)

+++ vm/flow_graph_compiler_x64.cc (working copy)

@@ -529,7 +529,6 @@

void FlowGraphCompiler::VisitClosureCall(ClosureCallComp* comp) {

- ASSERT(comp->context()->IsUse());

ASSERT(VerifyCallComputation(comp));

// The arguments to the stub include the closure. The arguments

// descriptor describes the closure's arguments (and so does not include

@@ -545,7 +544,6 @@

&StubCode::CallClosureFunctionLabel(),

PcDescriptors::kOther);

__ Drop(argument_count);

- __ popq(CTX);

}

« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/il_printer.cc » ('j') | no next file with comments »