Issue 10409003: Eliminate switches that are not on const ints or strings (as required in spec 0.09).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409003: Eliminate switches that are not on const ints or strings (as required in spec 0.09). (Closed)

Created:
8 years, 7 months ago by dgrove

Modified:
8 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate switches that are not on const ints or strings (as required in spec 0.09). Really wish we had enum. Committed: https://code.google.com/p/dart/source/detail?r=7751

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -106 lines)			Patch
M	lib/json/json.dart	View	2 chunks	+59 lines, -70 lines	2 comments	Download
M	samples/ui_lib/layout/GridLayout.dart	View	2 chunks	+12 lines, -15 lines	0 comments	Download
M	samples/ui_lib/layout/ViewLayout.dart	View	1 chunk	+16 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm :( The json change I like, the Dimension change I don't https://chromiumcodereview.appspot.com/10409003/diff/1/lib/json/json.dart File lib/json/json.dart ...

8 years, 7 months ago (2012-05-17 18:38:51 UTC) #2

dgrove

8 years, 7 months ago (2012-05-17 20:05:30 UTC) #3

https://chromiumcodereview.appspot.com/10409003/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10409003/diff/1/lib/json/json.dart#new...
lib/json/json.dart:522: _sb.add('{');
On 2012/05/17 18:38:51, sigmund wrote:
> strange... why is this line marked as different?

no idea. everything about the line looks right to me.

Expand Messages | Collapse Messages