Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: samples/ui_lib/layout/GridLayout.dart

Issue 10409003: Eliminate switches that are not on const ints or strings (as required in spec 0.09). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/ui_lib/layout/GridLayout.dart
===================================================================
--- samples/ui_lib/layout/GridLayout.dart (revision 7713)
+++ samples/ui_lib/layout/GridLayout.dart (working copy)
@@ -456,11 +456,10 @@
}
num _getGridContentSize() {
- switch (_dimension) {
- case Dimension.WIDTH:
- return _gridWidth;
- case Dimension.HEIGHT:
- return _gridHeight;
+ if (_dimension == Dimension.WIDTH) {
+ return _gridWidth;
+ } else if (_dimension == Dimension.HEIGHT) {
+ return _gridHeight;
}
}
@@ -491,16 +490,14 @@
int start, span;
List<GridTrack> tracks;
- switch (_dimension) {
- case Dimension.WIDTH:
- start = childLayout.column - 1;
- span = childLayout.columnSpan;
- tracks = _columnTracks;
- break;
- case Dimension.HEIGHT:
- start = childLayout.row - 1;
- span = childLayout.rowSpan;
- tracks = _rowTracks;
+ if (_dimension == Dimension.WIDTH) {
+ start = childLayout.column - 1;
+ span = childLayout.columnSpan;
+ tracks = _columnTracks;
+ } else if (_dimension == Dimension.HEIGHT) {
+ start = childLayout.row - 1;
+ span = childLayout.rowSpan;
+ tracks = _rowTracks;
}
assert(start >= 0 && span >= 1);

Powered by Google App Engine
This is Rietveld 408576698