Issue 10408059: Move registering to the enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408059: Move registering to the enqueuer. (Closed)

Created:
8 years, 7 months ago by ahe

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, karlklose, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move registering to the enqueuer. Committed: https://code.google.com/p/dart/source/detail?r=7903

Patch Set 1 : #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -58 lines)			Patch
M	dart/lib/compiler/implementation/compiler.dart	View	3 chunks	+3 lines, -31 lines	0 comments	Download
M	dart/lib/compiler/implementation/enqueue.dart	View	4 chunks	+34 lines, -4 lines	0 comments	Download
M	dart/lib/compiler/implementation/native_handler.dart	View	1 chunk	+11 lines, -8 lines	2 comments	Download
M	dart/lib/compiler/implementation/ssa/builder.dart	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/ssa/codegen.dart	View	11 chunks	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10408059/diff/2001/dart/lib/compiler/implementation/native_handler.dart File dart/lib/compiler/implementation/native_handler.dart (right): https://chromiumcodereview.appspot.com/10408059/diff/2001/dart/lib/compiler/implementation/native_handler.dart#newcode62 dart/lib/compiler/implementation/native_handler.dart:62: final worlds = [compiler.enqueuer.resolution, compiler.enqueuer.codegen]; Could 'worlds' be ...

8 years, 7 months ago (2012-05-23 11:48:59 UTC) #2

ahe

8 years, 7 months ago (2012-05-23 12:00:30 UTC) #3

Hi Nicolas,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10408059/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/native_handler.dart (right):

https://chromiumcodereview.appspot.com/10408059/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/native_handler.dart:62: final worlds =
[compiler.enqueuer.resolution, compiler.enqueuer.codegen];
On 2012/05/23 11:48:59, ngeoffray wrote:
> Could 'worlds' be placed in compiler instead?

I'm not really sure about this yet.

Expand Messages | Collapse Messages