Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 10407082: Reland: Migrate {Closure,Instance,Static}Call to use location-based code generation templates. (Closed)

Created:
8 years, 7 months ago by Florian Schneider
Modified:
8 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reland: Migrate {Closure,Instance,Static}Call to use location-based code generation templates. This is the same CL as http://codereview.chromium.org/10407077/ with compilation on ia32 fixed: Added missing empty function definitions in intermediate_language_ia32.cc. TBR=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=7835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -55 lines) Patch
M vm/flow_graph_compiler_x64.h View 2 chunks +6 lines, -1 line 0 comments Download
M vm/flow_graph_compiler_x64.cc View 4 chunks +7 lines, -51 lines 0 comments Download
M vm/intermediate_language.h View 7 chunks +38 lines, -3 lines 0 comments Download
M vm/intermediate_language_ia32.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M vm/intermediate_language_x64.cc View 2 chunks +87 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
8 years, 7 months ago (2012-05-22 00:28:21 UTC) #1
srdjan
lgtm
8 years, 7 months ago (2012-05-22 00:51:34 UTC) #2
srdjan
8 years, 7 months ago (2012-05-22 00:51:36 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698