Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: vm/intermediate_language.h

Issue 10407082: Reland: Migrate {Closure,Instance,Static}Call to use location-based code generation templates. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/flow_graph_compiler_x64.cc ('k') | vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language.h
===================================================================
--- vm/intermediate_language.h (revision 7834)
+++ vm/intermediate_language.h (working copy)
@@ -392,7 +392,10 @@
ClosureCallComp(ClosureCallNode* node,
intptr_t try_index,
ZoneGrowableArray<Value*>* arguments)
- : ast_node_(*node), try_index_(try_index), arguments_(arguments) { }
+ : ast_node_(*node),
+ try_index_(try_index),
+ arguments_(arguments),
+ location_summary_(MakeLocationSummary()) { }
DECLARE_COMPUTATION(ClosureCall)
@@ -408,10 +411,20 @@
virtual void PrintOperandsTo(BufferFormatter* f) const;
+ virtual LocationSummary* locs() const {
+ return location_summary_;
+ }
+
+ // Platform specific summary factory for this instruction.
+ LocationSummary* MakeLocationSummary();
+
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
const ClosureCallNode& ast_node_;
const intptr_t try_index_;
ZoneGrowableArray<Value*>* arguments_;
+ LocationSummary* location_summary_;
DISALLOW_COPY_AND_ASSIGN(ClosureCallComp);
};
@@ -430,7 +443,8 @@
function_name_(function_name),
arguments_(arguments),
argument_names_(argument_names),
- checked_argument_count_(checked_argument_count) {
+ checked_argument_count_(checked_argument_count),
+ location_summary_(MakeLocationSummary()) {
ASSERT(function_name.IsZoneHandle());
ASSERT(!arguments->is_empty());
ASSERT(argument_names.IsZoneHandle());
@@ -451,6 +465,15 @@
virtual void PrintOperandsTo(BufferFormatter* f) const;
+ virtual LocationSummary* locs() const {
+ return location_summary_;
+ }
+
+ // Platform specific summary factory for this instruction.
+ LocationSummary* MakeLocationSummary();
+
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
const intptr_t token_index_;
const intptr_t try_index_;
@@ -458,6 +481,7 @@
ZoneGrowableArray<Value*>* const arguments_;
const Array& argument_names_;
const intptr_t checked_argument_count_;
+ LocationSummary* location_summary_;
DISALLOW_COPY_AND_ASSIGN(InstanceCallComp);
};
@@ -541,7 +565,8 @@
try_index_(try_index),
function_(function),
argument_names_(argument_names),
- arguments_(arguments) {
+ arguments_(arguments),
+ location_summary_(MakeLocationSummary()) {
ASSERT(function.IsZoneHandle());
ASSERT(argument_names.IsZoneHandle());
}
@@ -562,12 +587,22 @@
virtual void PrintOperandsTo(BufferFormatter* f) const;
+ virtual LocationSummary* locs() const {
+ return location_summary_;
+ }
+
+ // Platform specific summary factory for this instruction.
+ LocationSummary* MakeLocationSummary();
+
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
const intptr_t token_index_;
const intptr_t try_index_;
const Function& function_;
const Array& argument_names_;
ZoneGrowableArray<Value*>* arguments_;
+ LocationSummary* location_summary_;
DISALLOW_COPY_AND_ASSIGN(StaticCallComp);
};
« no previous file with comments | « vm/flow_graph_compiler_x64.cc ('k') | vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698