Issue 10407064: Purge String operator+ from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10407064: Purge String operator+ from dart2js. (Closed)

Created:
8 years, 7 months ago by ahe

Modified:
8 years, 7 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, hausner

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Purge String operator+ from dart2js. Committed: https://code.google.com/p/dart/source/detail?r=7798

Patch Set 2 : Address review comment #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	dart/lib/compiler/implementation/dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/source_file.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/utils/compiler/build_helper.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

This should fix http://code.google.com/p/dart/issues/detail?id=3111

8 years, 7 months ago (2012-05-21 13:19:42 UTC) #1

karlklose

LGTM. https://chromiumcodereview.appspot.com/10407064/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/10407064/diff/1/dart/utils/compiler/build_helper.dart#newcode76 dart/utils/compiler/build_helper.dart:76: // Disable String operator+. This should only necessary ...

8 years, 7 months ago (2012-05-21 13:27:10 UTC) #2