dart/lib/compiler/implementation/source_file.dart - Issue 10407064: Purge String operator+ from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/source_file.dart

Issue 10407064: Purge String operator+ from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comment Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/source_file.dart

diff --git a/dart/lib/compiler/implementation/source_file.dart b/dart/lib/compiler/implementation/source_file.dart

index b8f138f924c1c083fdb762b4dc11073fb3f68d45..884d00854d181dd6172513dab2d0f4e820410609 100644

--- a/dart/lib/compiler/implementation/source_file.dart

+++ b/dart/lib/compiler/implementation/source_file.dart

@@ -67,7 +67,7 @@ class SourceFile {

if ((line + 2) < _lineStarts.length) {

textLine = text.substring(_lineStarts[line], _lineStarts[line+1]);

} else {

- textLine = text.substring(_lineStarts[line]) + '\n';

+ textLine = '${text.substring(_lineStarts[line])}\n';

}

int toColumn = Math.min(column + (end-start), textLine.length);

« no previous file with comments | « dart/lib/compiler/implementation/dart2js.dart ('k') | dart/utils/compiler/build_helper.dart » ('j') | no next file with comments »