Issue 10407018: Start porting fast typechecks to x64.

Issue 10407018: Start porting fast typechecks to x64. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Start porting fast typechecks to x64. Committed: https://code.google.com/p/dart/source/detail?r=7760

Patch Set 9 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -90 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4 5 6 7 8	1 chunk	+11 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4 5 6 7 8	14 chunks	+116 lines, -54 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3 4 5 6 7 8	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5 6 7 8	11 chunks	+49 lines, -20 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4 5 6 7 8	3 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5 6 7 8	6 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4 5 6 7 8	1 chunk	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5 6 7 8	5 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

I'll need more time tomorrow to review this change, since it does not look like ...

8 years, 7 months ago (2012-05-18 00:41:38 UTC) #2

regis

LGTM https://chromiumcodereview.appspot.com/10407018/diff/6004/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10407018/diff/6004/runtime/vm/flow_graph_builder.cc#newcode587 runtime/vm/flow_graph_builder.cc:587: if (instantiator_class.NumTypeParameters() > 0) { As discussed offline, ...

8 years, 7 months ago (2012-05-18 19:42:19 UTC) #3

srdjan

8 years, 7 months ago (2012-05-18 20:15:53 UTC) #4

https://chromiumcodereview.appspot.com/10407018/diff/6004/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10407018/diff/6004/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:587: if (instantiator_class.NumTypeParameters()
> 0) {
On 2012/05/18 19:42:19, regis wrote:
> As discussed offline, since you call this only if !dst_type.IsInstantiated(),
> you should be able to assert instantiator_class.NumTypeParameters() > 0.

Done.

https://chromiumcodereview.appspot.com/10407018/diff/6004/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:589: if (instantiator == NULL) {
On 2012/05/18 19:42:19, regis wrote:
> You should assert it is not NULL.

Added comment when it can be NULL.

Expand Messages | Collapse Messages