Start porting fast typechecks to x64.

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 90 matching lines @@
 
 // Inputs:
 // - RAX: object (preserved).
 // - RDX: optional instantiator type arguments (preserved).
 // Destroys RCX.
 // Returns:
 // - unchanged object in RAX and optional instantiator type arguments in RDX.
 // Note that this inlined code must be followed by the runtime_call code, as it
 // may fall through to it. Otherwise, this inline code will jump to the label
 // is_instance or to the label is_not_instance.
-void FlowGraphCompiler::GenerateInlineInstanceof(const AbstractType& type,
-                                                 Label* is_instance,
-                                                 Label* is_not_instance) {
+RawSubtypeTestCache* FlowGraphCompiler::GenerateInlineInstanceof(
+    intptr_t cid,
+    intptr_t token_index,
+    const AbstractType& type,
+    Label* is_instance,
+    Label* is_not_instance) {
   Label runtime_call;
   if (type.IsInstantiated()) {
     const Class& type_class = Class::ZoneHandle(type.type_class());
     const bool requires_type_arguments = type_class.HasTypeArguments();
     // A Smi object cannot be the instance of a parameterized class.
     // A class equality check is only applicable with a dst type of a
     // non-parameterized class or with a raw dst type of a parameterized class.
     if (requires_type_arguments) {
       const AbstractTypeArguments& type_arguments =
           AbstractTypeArguments::Handle(type.arguments());
@@ skipping 140 matching lines @@
       __ movq(RCX, FieldAddress(RCX, Type::type_class_offset()));
       __ movq(R10, FieldAddress(RCX, Class::type_parameters_offset()));
       // Check that class of type has no type parameters.
       __ cmpq(R10, raw_null);
       __ j(NOT_EQUAL, &runtime_call, Assembler::kNearJump);
       // TODO(srdjan): Implement subtype test cache.
       // Fall through to runtime call.
     }
   }
   __ Bind(&runtime_call);
+  return SubtypeTestCache::null();
 }
 
 
 // Optimize assignable type check by adding inlined tests for:
 // - NULL -> return NULL.
 // - Smi -> compile time subtype check (only if dst class is not parameterized).
 // - Class equality (only if class is not parameterized).
 // Inputs:
 // - RAX: object.
-// - RDX: optional instantiator type arguments.
+// - RDX: instantiator type arguments or raw_null.
+// - RCX: instantiator or raw_null.
 // Destroys RCX and RDX.
 // Returns:
 // - object in RAX for successful assignable check (or throws TypeError).
 // Performance notes: positive checks must be quick, negative checks can be slow
 // as they throw an exception.
 void FlowGraphCompiler::GenerateAssertAssignable(intptr_t cid,
                                                  intptr_t token_index,
                                                  intptr_t try_index,
                                                  const AbstractType& dst_type,
                                                  const String& dst_name) {
   ASSERT(FLAG_enable_type_checks);
   ASSERT(token_index >= 0);
   ASSERT(!dst_type.IsNull());
   ASSERT(dst_type.IsFinalized());
+  // Assignable check is skipped in FlowGraphBuilder, not here.
   ASSERT(dst_type.IsMalformed() ||
          (!dst_type.IsDynamicType() && !dst_type.IsObjectType()));
   ASSERT(!dst_type.IsVoidType());
-
+  __ pushq(RCX);  // Temporary store instantiator on stack.
   // A null object is always assignable and is returned as result.
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   Label is_assignable, runtime_call;
   __ cmpq(RAX, raw_null);
   __ j(EQUAL, &is_assignable);
 
   // Generate throw new TypeError() if the type is malformed.
   if (dst_type.IsMalformed()) {
     const Error& error = Error::Handle(dst_type.malformed_error());
     const String& error_message = String::ZoneHandle(
         String::NewSymbol(error.ToErrorCString()));
     __ PushObject(Object::ZoneHandle());  // Make room for the result.
     __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
     __ pushq(RAX);  // Push the source object.
     __ PushObject(dst_name);  // Push the name of the destination.
     __ PushObject(error_message);
     GenerateCallRuntime(cid,
                         token_index,
                         try_index,
                         kMalformedTypeErrorRuntimeEntry);
     // We should never return here.
     __ int3();
 
     __ Bind(&is_assignable);  // For a null object.
     return;
   }
 
   // Generate inline type check, linking to runtime call if not assignable.
-  GenerateInlineInstanceof(dst_type, &is_assignable, &runtime_call);
-
+  SubtypeTestCache& test_cache = SubtypeTestCache::ZoneHandle();
+  test_cache = GenerateInlineInstanceof(cid, token_index, dst_type,
+                                        &is_assignable, &runtime_call);
   __ Bind(&runtime_call);
+  __ movq(RCX, Address(RSP, 0));  // Get instantiator.
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
-  __ pushq(raw_null);  // TODO(srdjan): Instantiator.
-  if (dst_type.IsInstantiated()) {
-    __ pushq(raw_null);  // Null instantiator type arguments.
-  } else {
-    __ pushq(RDX);  // Instantiator type arguments.
-  }
+  __ pushq(RCX);  // Instantiator.
+  __ pushq(RDX);  // Instantiator type arguments.
   __ PushObject(dst_name);  // Push the name of the destination.
-  __ pushq(raw_null);  // SubtypeTestCache not yet supported.
+  __ LoadObject(RAX, test_cache);
+  __ pushq(RAX);
   GenerateCallRuntime(cid,
                       token_index,
                       try_index,
                       kTypeCheckRuntimeEntry);
   // Pop the parameters supplied to the runtime entry. The result of the
   // type check runtime call is the checked value.
   __ Drop(8);
   __ popq(RAX);
 
   __ Bind(&is_assignable);
+  __ popq(RCX);  // Remove pushed instantiator.
 }
 
 
 void FlowGraphCompiler::LoadValue(Register dst, Value* value) {
   if (value->IsConstant()) {
     ConstantVal* constant = value->AsConstant();
     if (constant->value().IsSmi()) {
       int64_t imm = reinterpret_cast<int64_t>(constant->value().raw());
       __ movq(dst, Immediate(imm));
     } else {
@@ skipping 10 matching lines @@
   LoadValue(RAX, val);
 }
 
 
 void FlowGraphCompiler::VisitConstant(ConstantVal* val) {
   LoadValue(RAX, val);
 }
 
 
 void FlowGraphCompiler::VisitAssertAssignable(AssertAssignableComp* comp) {
-  if (comp->instantiator_type_arguments() != NULL) {
-    __ popq(RDX);
+  const Immediate raw_null =
+      Immediate(reinterpret_cast<intptr_t>(Object::null()));
+  if (comp->instantiator_type_arguments() == NULL) {
+    __ movq(RDX, raw_null);
+  } else {
+    LoadValue(RDX, comp->instantiator_type_arguments());
+  }
+  if (comp->instantiator() == NULL) {
+    __ movq(RCX, raw_null);
+  } else {
+    LoadValue(RCX, comp->instantiator());
   }
   LoadValue(RAX, comp->value());
   GenerateAssertAssignable(comp->cid(),
                            comp->token_index(),
                            comp->try_index(),
                            comp->dst_type(),
                            comp->dst_name());
 }
 
 
@@ skipping 350 matching lines @@
   __ Bind(&done);
 }
 
 
 // Optimize instanceof type test by adding inlined tests for:
 // - NULL -> return false.
 // - Smi -> compile time subtype check (only if dst class is not parameterized).
 // - Class equality (only if class is not parameterized).
 // Inputs:
 // - RAX: object.
-// - RDX: optional instantiator type arguments.
+// - RDX: oinstantiator type arguments or raw_null.
+// - RCX: instantiator or raw_null.
 // Destroys RCX and RDX.
 // Returns:
 // - true or false in RAX.
 void FlowGraphCompiler::GenerateInstanceOf(intptr_t cid,
                                            intptr_t token_index,
                                            intptr_t try_index,
                                            const AbstractType& type,
                                            bool negate_result) {
   ASSERT(type.IsFinalized() && !type.IsMalformed());
   const Bool& bool_true = Bool::ZoneHandle(Bool::True());
   const Bool& bool_false = Bool::ZoneHandle(Bool::False());
 
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   Label is_instance, is_not_instance;
+  __ pushq(RCX);  // Temporary store instantiator on stack.
   // If type is instantiated and non-parameterized, we can inline code
   // checking whether the tested instance is a Smi.
   if (type.IsInstantiated()) {
     // A null object is only an instance of Object and Dynamic, which has
     // already been checked above (if the type is instantiated). So we can
     // return false here if the instance is null (and if the type is
     // instantiated).
     // We can only inline this null check if the type is instantiated at compile
     // time, since an uninstantiated type at compile time could be Object or
     // Dynamic at run time.
     __ cmpq(RAX, raw_null);
     __ j(EQUAL, &is_not_instance);
   }
 
   // Generate inline instanceof test.
-  GenerateInlineInstanceof(type, &is_instance, &is_not_instance);
+  SubtypeTestCache& test_cache = SubtypeTestCache::ZoneHandle();
+  test_cache = GenerateInlineInstanceof(cid, token_index, type,
+                                        &is_instance, &is_not_instance);
 
   // Generate runtime call.
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
   __ pushq(raw_null);  // TODO(srdjan): Pass instantiator instead of null.
   if (type.IsInstantiated()) {
     __ pushq(raw_null);  // Null instantiator type arguments.
@@ skipping 17 matching lines @@
   }
   __ jmp(&done, Assembler::kNearJump);
 
   __ Bind(&is_not_instance);
   __ LoadObject(RAX, negate_result ? bool_true : bool_false);
   __ jmp(&done, Assembler::kNearJump);
 
   __ Bind(&is_instance);
   __ LoadObject(RAX, negate_result ? bool_false : bool_true);
   __ Bind(&done);
+  __ popq(RCX);  // Remove pushed instantiator.
 }
 
 
 void FlowGraphCompiler::VisitInstanceOf(InstanceOfComp* comp) {
-  if (comp->type_arguments() != NULL) {
-    __ popq(RDX);
+  const Immediate raw_null =
+      Immediate(reinterpret_cast<intptr_t>(Object::null()));
+  if (comp->type_arguments() == NULL) {
+    __ movq(RDX, raw_null);
+  } else {
+    LoadValue(RDX, comp->type_arguments());
+  }
+  if (comp->instantiator() == NULL) {
+    __ movq(RCX, raw_null);
+  } else {
+    LoadValue(RCX, comp->instantiator());
   }
   LoadValue(RAX, comp->value());
   GenerateInstanceOf(comp->cid(),
                      comp->token_index(),
                      comp->try_index(),
                      comp->type(),
                      comp->negate_result());
 }
 
 
@@ skipping 870 matching lines @@
 
 
 void FlowGraphCompiler::FinalizeComments(const Code& code) {
   code.set_comments(assembler_->GetCodeComments());
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64